[PATCH 4/5] net/tls: split tls_rx_reader_lock

Sagi Grimberg sagi at grimberg.me
Mon Jul 3 03:06:58 PDT 2023



On 7/3/23 12:04, Hannes Reinecke wrote:
> Split tls_rx_reader_{lock,unlock} into an 'acquire/release' and
> the actual locking part.
> With that we can use the tls_rx_reader_lock in situations where
> the socket is already locked.
> 
> Suggested-by: Sagi Grimberg <sagi at grimberg.me>
> Signed-off-by: Hannes Reinecke <hare at suse.de>
> ---
>   net/tls/tls_sw.c | 38 ++++++++++++++++++++++----------------
>   1 file changed, 22 insertions(+), 16 deletions(-)
> 
> diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c
> index 9aef45e870a5..d0636ea13009 100644
> --- a/net/tls/tls_sw.c
> +++ b/net/tls/tls_sw.c
> @@ -1848,13 +1848,10 @@ tls_read_flush_backlog(struct sock *sk, struct tls_prot_info *prot,
>   	return sk_flush_backlog(sk);
>   }
>   
> -static int tls_rx_reader_lock(struct sock *sk, struct tls_sw_context_rx *ctx,
> -			      bool nonblock)
> +static int tls_rx_reader_acquire(struct sock *sk, struct tls_sw_context_rx *ctx,
> +				 bool nonblock)

Nit: I still think tls_rx_reader_enter/tls_rx_reader_exit are more
appropriate names.



More information about the Linux-nvme mailing list