[PATCH] nvme-pci: fix resume after AER recovery

Keith Busch kbusch at kernel.org
Tue Jan 31 07:22:11 PST 2023


On Tue, Jan 31, 2023 at 09:58:28AM +0100, Christoph Hellwig wrote:
> On Mon, Jan 30, 2023 at 11:43:28AM -0700, Keith Busch wrote:
> > > Why isn't slot_reset being called after error_detected? Driver should be
> > > returning "RESULT_NEEDS_RESET", which should have the pcie error handling
> > > always invoke the slot_reset callback.
> > 
> > Are you using an older kernel that doesn't have
> > 
> >   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=387c72cdd7fb6bef650fb078d0f6ae9682abf631
> 
> Oh, that does looks like the real fix.  That being said, what is
> the point of flushing the reset_wor in nvme_error_resume?

It's so we don't try to handle a new error or remove before finishing recovery
from the first one.



More information about the Linux-nvme mailing list