[PATCH 01/23] block: factor out a bvec_set_page helper
Bart Van Assche
bvanassche at acm.org
Mon Jan 30 11:24:40 PST 2023
On 1/30/23 09:09, Bart Van Assche wrote:
> On 1/30/23 01:21, Christoph Hellwig wrote:
>> Add a helper to initialize a bvec based of a page pointer. This will
>> help
>> removing various open code bvec initializations.
>
> Why do you want to remove the open-coded bvec initializations? What is
> wrong with open-coding bvec initialization? This patch series modifies a
> lot of code but does not improve code readability. Anyone who encounters
> code that uses the new function bvec_set_page() has to look up the
> definition of that function to figure out what it does.
Please ignore the above question - I just noticed that this question has
been answered in the cover letter.
Bart.
More information about the Linux-nvme
mailing list