[PATCH 01/23] block: factor out a bvec_set_page helper
Christoph Hellwig
hch at lst.de
Mon Jan 30 02:36:19 PST 2023
On Mon, Jan 30, 2023 at 10:33:36AM +0000, David Howells wrote:
> Christoph Hellwig <hch at lst.de> wrote:
>
> > +static inline void bvec_set_page(struct bio_vec *bv, struct page *page,
> > + unsigned int len, unsigned int offset)
>
> Could you swap len and offset around? It reads better offset first. You move
> offset into the page and then do something with len bytes.
This matches bio_add_page and the order inside bio_vec itself. willy
wanted to switch it around for bio_add_folio but Jens didn't like it,
so I'll stick to the current convention in this area as well.
More information about the Linux-nvme
mailing list