[PATCH v9 01/25] net: Introduce direct data placement tcp offload

[Paolo Abeni]

Hi,

On Thu, 2023-01-26 at 09:47 +0000, Shai Malin wrote:
> On Fri, 20 Jan 2023 at 10:52, Paolo Abeni wrote:
> 
> > Have you considered avoiding adding the above fields here, and instead
> > pass them as argument for the setup() H/W offload operation?
> 
> After researching the implication of such a change, we don’t believe it's right.
> This entire work was designed to be based on the sock structure, and this approach
> will be needed also for the next part of our work (Tx), in which we will use the 
> ops and the queue also from the socket.
> 
> We defined the ULD_DDP as a generic layer that can support different 
> vendors/devices and different ULPs so using only one ops will make it 
> more difficult to maintain from our point of view.

I'm fine with the above. 

> I will also add that we are addressing review comments for 1.5 years in order 
> to fine tune this design, and such a change will open the fundamentals.

I understand my above comment landed quite too late, but I guessed it
was better to ask the question this late then never.

No opposition to the current design on my side.

Thanks,

Paolo