[PATCHv2] nvme: always initialize known command effects

Keith Busch kbusch at kernel.org
Tue Jan 24 13:42:27 PST 2023


On Mon, Jan 23, 2023 at 11:53:59AM -0700, Keith Busch wrote:
> On Mon, Jan 23, 2023 at 07:02:19PM +0100, Christoph Hellwig wrote:
> > On Mon, Jan 23, 2023 at 10:42:45AM -0700, Keith Busch wrote:
> > > xarray lookups are pretty slow in comparison, though. This is in a fast
> > > path now, so I think we need to keep caching it.
> > 
> > Is it?
> 
> No, I was mistaken. I was thinking of uring_cmd for fast path, but that
> doesn't go through here.

Oh, I'm an idiot: uring_cmd recently does now use this through
nvme_cmd_allowed(), so the cached effects are needed over the slower xarray
lookup.



More information about the Linux-nvme mailing list