[PATCH] nvme-pci: Switch back to sync probe to fix rootfs mount regression
Ville Syrjala
ville.syrjala at linux.intel.com
Mon Jan 23 16:45:42 PST 2023
From: Ville Syrjälä <ville.syrjala at linux.intel.com>
Async probe caused a regression where we fail to find the
rootfs in time, leading an unbootable machine.
rootdelay=1 can be used as a workaround but that needlessly
slows down the boot by a whole extra second.
To get the best of both worlds perhaps there should be
some kind of async probe flush/sync just before attempting
to mount the rootfs?
In the meantime just switch back to a sync probe to fix
the regression.
Cc: linux-nvme at lists.infradead.org
Cc: Christoph Hellwig <hch at lst.de>
Cc: Keith Busch <kbusch at kernel.org>
Cc: Chaitanya Kulkarni <kch at nvidia.com>
Cc: Gerd Bayer <gbayer at linux.ibm.com>
Cc: Sagi Grimberg <sagi at grimberg.me>
Cc: Jens Axboe <axboe at fb.com>
Fixes: eac3ef262941 ("nvme-pci: split the initial probe from the rest path")
Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
drivers/nvme/host/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 1ff8843bc4b3..d0f5e93d977e 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3514,7 +3514,6 @@ static struct pci_driver nvme_driver = {
.remove = nvme_remove,
.shutdown = nvme_shutdown,
.driver = {
- .probe_type = PROBE_PREFER_ASYNCHRONOUS,
#ifdef CONFIG_PM_SLEEP
.pm = &nvme_dev_pm_ops,
#endif
--
2.39.1
More information about the Linux-nvme
mailing list