[PATCH rdma-next 11/13] nvme: Introduce a local variable
Chaitanya Kulkarni
chaitanyak at nvidia.com
Mon Jan 16 16:32:59 PST 2023
On 1/16/23 05:05, Leon Romanovsky wrote:
> From: Israel Rukshin <israelr at nvidia.com>
>
> The patch doesn't change any logic.
>
> Signed-off-by: Israel Rukshin <israelr at nvidia.com>
> Signed-off-by: Leon Romanovsky <leon at kernel.org>
> ---
> drivers/nvme/host/core.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 7be562a4e1aa..51a9880db6ce 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1870,6 +1870,7 @@ static void nvme_update_disk_info(struct gendisk *disk,
> sector_t capacity = nvme_lba_to_sect(ns, le64_to_cpu(id->nsze));
> unsigned short bs = 1 << ns->lba_shift;
> u32 atomic_bs, phys_bs, io_opt = 0;
> + struct nvme_ctrl *ctrl = ns->ctrl;
>
I don't think this patch is needed, existing code is more readable and
gives much clarity that we are accessing ctrl from namespace since we
are in nvme_update_disk_info() which is namespace based.
-ck
More information about the Linux-nvme
mailing list