[PATCH v8 03/25] net/ethtool: add ULP_DDP_{GET,SET} operations for caps and stats

Aurelien Aptel aaptel at nvidia.com
Fri Jan 13 06:16:10 PST 2023


Jakub Kicinski <kuba at kernel.org> writes:
> The standard ethtool interface should expose the accumulated stats.
> The stats of finer granularity need to be reported on the object to
> which they are scoped.
>
> I'm still yet to find any practical use for per-queue stats in
> production.
>
> IOW report the cumulative per device stats in ethtool -I --your-switch.
> The per-queue stats can go to ethtool -S until someone actually finds
> a good reason to read them in production..

We currently don't have justifications for the per queue stats,
hence we will move it out of the series at this point. We might
reconsider it in the future.

We'll continue with your suggestion with global dynamic strings to
avoid having the need to update ethtool with the additional counters
we are planning to add as part of the incremental features (TX, target
mode, ...).

Thanks




More information about the Linux-nvme mailing list