[PATCH 1/2] nvme-apple: Do not try to shut down the controller twice
Hector Martin
marcan at marcan.st
Tue Jan 10 20:36:13 PST 2023
The blamed commit stopped explicitly disabling the controller when we do
a controlled shutdown, but apple_nvme_reset_work was only checking for
the disable bit before deciding to issue another disable. Check for the
shutdown state too, to avoid breakage.
This issue does not affect nvme-pci, since it only issues controller
shutdowns when the system is actually shutting down anyway.
Fixes: c76b8308e4c9 ("nvme-apple: fix controller shutdown in apple_nvme_disable")
Signed-off-by: Hector Martin <marcan at marcan.st>
---
drivers/nvme/host/apple.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/apple.c b/drivers/nvme/host/apple.c
index e13a992b6096..1961376447dc 100644
--- a/drivers/nvme/host/apple.c
+++ b/drivers/nvme/host/apple.c
@@ -1023,7 +1023,8 @@ static void apple_nvme_reset_work(struct work_struct *work)
goto out;
}
- if (anv->ctrl.ctrl_config & NVME_CC_ENABLE)
+ if (anv->ctrl.ctrl_config & NVME_CC_ENABLE &&
+ !(anv->ctrl.ctrl_config & NVME_CC_SHN_MASK))
apple_nvme_disable(anv, false);
/* RTKit must be shut down cleanly for the (soft)-reset to work */
--
2.35.1
More information about the Linux-nvme
mailing list