nvmet_check_data_len() wrong behavior for nvme admin set features cmd

[Engel, Amit]

Ok sure

Thanks,
Amit

-----Original Message-----
From: Sagi Grimberg <sagi at grimberg.me> 
Sent: Sunday, 8 January 2023 17:30
To: Engel, Amit <Amit.Engel at Dell.com>
Cc: linux-nvme at lists.infradead.org; Grupi, Elad <Elad.Grupi at dell.com>; Zinger, Eldad <Eldad.Zinger at dell.com>
Subject: Re: nvmet_check_data_len() wrong behavior for nvme admin set features cmd


[EXTERNAL EMAIL] 


> By the way, why not always call nvmet_check_data_len_lte() ?
> 
> Don’t we agree that the host is allowed to send sgl describing a buffer that is larger than the payload for any nvme io/admin cmd ?
> (and not only for dsm / set_features cmd)

I think we're better off with a tighter check, to avoid possible bugs.