[PATCH] Add quirk for ADATA SX6000PNP

[Daniel Wagner]

Hi Ivan,

On Tue, Feb 28, 2023 at 12:10:31PM +0300, Ivan Rubinov wrote:
> With this patch it works nice.
> 
> 
> Signed-off-by: Ivan Rubinov<linuxkernelpatch8234 at riseup.net>
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index d839689..3f4da40 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3480,6 +3480,8 @@ static const struct pci_device_id nvme_id_table[] = {
>      { PCI_DEVICE(0x10ec, 0x5762),   /* ADATA SX6000LNP */
>          .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
>                  NVME_QUIRK_BOGUS_NID, },
> +    { PCI_DEVICE(0x10ec, 0x5763),   /* ADATA SX6000PNP */
> +                .driver_data = NVME_QUIRK_BOGUS_NID, },
>      { PCI_DEVICE(0x1cc1, 0x8201),   /* ADATA SX8200PNP 512GB */
>          .driver_data = NVME_QUIRK_NO_DEEPEST_PS |
>                  NVME_QUIRK_IGNORE_DEV_SUBNQN, },

Right this is exactly what went in:

5f69f009b7c4 ("nvme-pci: add bogus ID quirk for ADATA SX6000PNP")

> Kernel log:
> 
> [    6.852254] nvme nvme0: pci function 0000:01:00.0
> [    6.855936] nvme nvme1: pci function 0000:04:00.0
> [    7.071947] nvme nvme1: failed to set APST feature (2)
> [    7.073201] nvme nvme0: failed to set APST feature (2)
> [    7.094109] nvme nvme0: allocated 64 MiB host memory buffer.
> [    7.098544] nvme nvme1: allocated 64 MiB host memory buffer.
> [    7.125205] nvme nvme0: 7/0/0 default/read/poll queues
> [    7.128853] nvme nvme1: 7/0/0 default/read/poll queues
> [    7.137040] nvme nvme0: Ignoring bogus Namespace Identifiers
> [    7.140688] nvme nvme1: Ignoring bogus Namespace Identifiers
> [    7.142240]  nvme0n1: p1
> [    7.145537]  nvme1n1: p1 p2

Thanks for double checking. The NVME_QUIRK_IGNORE_DEV_SUBNQN would be necessary
if you see something like this in the log:

  nvme nvme1: ignoring ctrl due to duplicate subnqn (xxx)

Obviously, the absence doesn't mean that these devices do not suffer from the
problem but we usually don't add quirks on suspicions. If the above error
message pops up we can still add the quirk. So all is good after all.

Daniel