[PATCH v4 13/18] nvme: Add pr_ops read_reservation support
kernel test robot
lkp at intel.com
Fri Feb 24 13:04:09 PST 2023
Hi Mike,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on jejb-scsi/for-next axboe-block/for-next linus/master v6.2 next-20230224]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Mike-Christie/block-Rename-BLK_STS_NEXUS-to-BLK_STS_RESV_CONFLICT/20230225-024505
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link: https://lore.kernel.org/r/20230224174502.321490-14-michael.christie%40oracle.com
patch subject: [PATCH v4 13/18] nvme: Add pr_ops read_reservation support
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230225/202302250448.cEVYdC1I-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/f66174eef73e332bdca3a158541875a4c2e617d1
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Mike-Christie/block-Rename-BLK_STS_NEXUS-to-BLK_STS_RESV_CONFLICT/20230225-024505
git checkout f66174eef73e332bdca3a158541875a4c2e617d1
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/nvme/host/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp at intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302250448.cEVYdC1I-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/nvme/host/pr.c: In function 'block_pr_type_from_nvme':
>> drivers/nvme/host/pr.c:43:24: warning: implicit conversion from 'enum nvme_pr_type' to 'enum pr_type' [-Wenum-conversion]
43 | return NVME_PR_EXCLUSIVE_ACCESS_ALL_REGS;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +43 drivers/nvme/host/pr.c
28
29 static enum pr_type block_pr_type_from_nvme(enum nvme_pr_type type)
30 {
31 switch (type) {
32 case NVME_PR_WRITE_EXCLUSIVE:
33 return PR_WRITE_EXCLUSIVE;
34 case NVME_PR_EXCLUSIVE_ACCESS:
35 return PR_EXCLUSIVE_ACCESS;
36 case NVME_PR_WRITE_EXCLUSIVE_REG_ONLY:
37 return PR_WRITE_EXCLUSIVE_REG_ONLY;
38 case NVME_PR_EXCLUSIVE_ACCESS_REG_ONLY:
39 return PR_EXCLUSIVE_ACCESS_REG_ONLY;
40 case NVME_PR_WRITE_EXCLUSIVE_ALL_REGS:
41 return PR_WRITE_EXCLUSIVE_ALL_REGS;
42 case NVME_PR_EXCLUSIVE_ACCESS_ALL_REGS:
> 43 return NVME_PR_EXCLUSIVE_ACCESS_ALL_REGS;
44 }
45
46 return 0;
47 }
48
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
More information about the Linux-nvme
mailing list