[PATCH] nvme-pci: refresh visible attrs for cmb attributes

Linux regression tracking (Thorsten Leemhuis) regressions at leemhuis.info
Thu Feb 16 21:30:38 PST 2023


On 16.02.23 17:44, Keith Busch wrote:
> From: Keith Busch <kbusch at kernel.org>

Thx for looking into this and creating a fix so quickly.

> The sysfs group containing the cmb attributes is registered before the
> driver knows if they need to be visible or not. Update the group when
> cmb attributes are known to exist so the visibility setting is correct.

There are two small details that would be nice to have.

Having a

Reported-by: michallinuxstuff <michallinuxstuff at gmail.com>

here would be fair.

> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217037
> Fixes: 86adbf0cdb9ec65 ("nvme: simplify transport specific device attribute handling")

And a

Cc: stable at vger.kernel.org # 6.1.y

here would be wise to ensure this is fixed in 6.1 as well, as the change
apparently was backported [no, a fixes tag is not enough to ensure that].

> Signed-off-by: Keith Busch <kbusch at kernel.org>
> [...]
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.



More information about the Linux-nvme mailing list