[PATCH 3/3] nvme: make 'at_head' parameter for __nvme_submit_sync_cmd() boolean

Kanchan Joshi joshi.k at samsung.com
Thu Feb 9 06:24:48 PST 2023


On Thu, Feb 09, 2023 at 11:59:49AM +0100, Hannes Reinecke wrote:
>On 2/9/23 06:20, Christoph Hellwig wrote:
>>On Wed, Feb 08, 2023 at 04:17:20PM +0100, Hannes Reinecke wrote:
>>>Use a boolean for the 'at_head' parameter in __nvme_submit_sync_cmd()
>>>to improve readability and consistency; it's being converted into a
>>>boolean anyway.
>>
>>I'd much rather have an INSERT_AT_HEAD bit flag, going all the
>>way down to the block layer.  The use of a boolean for this (and
>>also some other things in the block layer issue path) is really confusing.
>
>I do agree. But that turns out to be a larger and more complex 
>patchset, which I'd rather send as a separate thingie after this one 
>is done.
>Otherwise it'll hold of this patchset, and really is an unrelated issue.

main patch (#2) is no longer coupled to other two now.


More information about the Linux-nvme mailing list