[PATCH 3/3] nvme: make 'at_head' parameter for __nvme_submit_sync_cmd() boolean

Christoph Hellwig hch at lst.de
Wed Feb 8 21:20:18 PST 2023


On Wed, Feb 08, 2023 at 04:17:20PM +0100, Hannes Reinecke wrote:
> Use a boolean for the 'at_head' parameter in __nvme_submit_sync_cmd()
> to improve readability and consistency; it's being converted into a
> boolean anyway.

I'd much rather have an INSERT_AT_HEAD bit flag, going all the
way down to the block layer.  The use of a boolean for this (and
also some other things in the block layer issue path) is really confusing.



More information about the Linux-nvme mailing list