Timberland nvme-cli/libnvme upstream merge - dbus dependency.

[Daniel Wagner]

On Fri, Feb 03, 2023 at 12:43:32PM -0500, John Meneghini wrote:
> On 2/3/23 12:30, Keith Busch wrote:
> > > The current nvme-cli meson.build configuration for libnvme is always pulling the
> > > fallback. A workaround is to build libnvme as separate step as you would do when
> > > packaging.
> > I'm just trying to build this right now on an embedded system, and my goodness,
> > it is fucking painful. It's a bare-bones busybox enviroment with no internet
> > connection. Just getting meson on there was unpleasant, and now the build just
> > gives up with the failed dependencies.
> > 
> 
> Here's how I solved the problem on my redhat platforms: fedora36, centos9 and rhel-8.6
> 
> $ sudo dnf update -y
> $ sudo dnf install -y meson cmake dbus-devel libuuid libuuid-devel libuuid-debuginfo json-c-devel json-c-debuginfo json-c \
>        json-c-doc libhugetlbfs libhugetlbfs-devel libhugetlbfs-lib clang openssl openssl-devel dbus-devel
>                                                                                                 ^^^^^^^^

FWIW, the libuuid depenency is gone. The dependencies on hugetablefs and OpenSSL
should be autodected and not break the build if they are missing.

The dbus build can fail when an older version of Meson is used. The D-Bus'
meson.build fail is using a feature which is only present in newer version of
Meson. I've send a bug fix to the D-Bus project to address this. Though you
can explicitly disable the libdbus build as Martin has pointed out.

> Every time I find a missing library or package I add it to my tool chain
> because the meson fallback/compile stuff is always broken and full of bugs.

What is the problem? 'always broken and full of bugs' is a very generic complain.

Also you are not fored to use the subproject feature of Meson. This is optional
and if you don't like it just build the libnvme library as it was previously as
seperate step. Overall, the Meson tools chains very flexible to use.

Anyway, it is possible to add additional CI build targets to catch build bugs
early.