[PATCH] nvme: retry commands if DNR bit is not set

[Jens Axboe]

On 2/1/23 6:09 AM, Christoph Hellwig wrote:
> On Wed, Feb 01, 2023 at 12:50:01PM +0100, Hannes Reinecke wrote:
>> Add a 'retry' argument to __nvme_submit_sync_cmd() to instruct
>> the function to not set the FAILFAST_DRIVER bit for the command,
>> causing it to be retried in nvme_decide_disposition() if the DNR
>> bit is not set in the command result.
>> And modify the authentication code to allow for retries.
> 
> This is missing the why.  And maybe we can find a better interace than
> a magic bool flag.

The bool addition is awful, I think it's about high time to refactor
that part of the interface rather than piling more junk on top. It's
at 8 arguments even without this change...

-- 
Jens Axboe