[PATCH -next] nvme: switch to use kmemdup_nul() helper
Ruan Jinjie
ruanjinjie at huawei.com
Tue Aug 15 01:59:27 PDT 2023
Use kmemdup_nul() helper instead of open-coding to
simplify the code.
Signed-off-by: Ruan Jinjie <ruanjinjie at huawei.com>
---
drivers/nvme/host/sysfs.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c
index 212e1b05d298..8d60948be485 100644
--- a/drivers/nvme/host/sysfs.c
+++ b/drivers/nvme/host/sysfs.c
@@ -435,10 +435,9 @@ static ssize_t nvme_ctrl_dhchap_secret_store(struct device *dev,
if (memcmp(buf, "DHHC-1:", 7))
return -EINVAL;
- dhchap_secret = kzalloc(count + 1, GFP_KERNEL);
+ dhchap_secret = kmemdup_nul(buf, count, GFP_KERNEL);
if (!dhchap_secret)
return -ENOMEM;
- memcpy(dhchap_secret, buf, count);
nvme_auth_stop(ctrl);
if (strcmp(dhchap_secret, opts->dhchap_secret)) {
struct nvme_dhchap_key *key, *host_key;
@@ -493,10 +492,9 @@ static ssize_t nvme_ctrl_dhchap_ctrl_secret_store(struct device *dev,
if (memcmp(buf, "DHHC-1:", 7))
return -EINVAL;
- dhchap_secret = kzalloc(count + 1, GFP_KERNEL);
+ dhchap_secret = kmemdup_nul(buf, count, GFP_KERNEL);
if (!dhchap_secret)
return -ENOMEM;
- memcpy(dhchap_secret, buf, count);
nvme_auth_stop(ctrl);
if (strcmp(dhchap_secret, opts->dhchap_ctrl_secret)) {
struct nvme_dhchap_key *key, *ctrl_key;
--
2.34.1
More information about the Linux-nvme
mailing list