[PATCH v2] nvmet-tcp: fix data digest calculation for multiple H2CData PDUs
Sagi Grimberg
sagi at grimberg.me
Sun Aug 13 07:09:19 PDT 2023
>>>> What is the case for data_length=0 ? I'm not entirely clear how this can
>>>> happen.
>>>
>>> This can happen if H2CData PDU data length is not a multiple of target page size.
>>>
>>> For example if transfer length is 32K, page size is 4K and H2CData PDU data length is 6K,
>>> host will send 6 H2CData PDUs, for the last PDU iov->bv_offset = 2K,
>>> iov->bv_len = 2K and data_length = 2K.
>>
>> I understand.
>>
>> Looking into this, I'm almost thinking we should just give up and
>> iterate. at this point it unnecessarily complicates the code...
>
> Should I resend v1?
Yes please.
More information about the Linux-nvme
mailing list