[PATCH rfc 6/6] nvme-fabrics: expose support for traddr as dns names to userspace

[Hannes Reinecke]

On 7/24/23 11:20, Sagi Grimberg wrote:
> userspace needs to know that the kernel is capable of doing a dns
> query, so expose a custom opt called "dns_ip_traddr" which is not
> an argument, but rather indication of support for dns names for
> ip based traddr.
> 
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> ---
>   drivers/nvme/host/fabrics.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
> index fadd25538d1b..6a7e8cbdaf69 100644
> --- a/drivers/nvme/host/fabrics.c
> +++ b/drivers/nvme/host/fabrics.c
> @@ -1331,6 +1331,7 @@ static void __nvmf_concat_opt_tokens(struct seq_file *seq_file)
>   		seq_puts(seq_file, ",");
>   		seq_puts(seq_file, tok->pattern);
>   	}
> +	seq_puts(seq_file, ",dns_ip_traddr");
>   	seq_puts(seq_file, "\n");
>   }
>   

Don't we need to update the parser to accept this option, too?
After all, the implication is that all tokens in the output can be used 
as valid tokens for the connect string ...

Cheers,

Hannes