[PATCH 15/16] nvmet-tcp: enable TLS handshake upcall

[Hannes Reinecke]

On 8/9/23 12:51, Sagi Grimberg wrote:
> 
> 
> On 8/8/23 19:53, Hannes Reinecke wrote:
>> Add functions to start the TLS handshake upcall when
>> the TCP TSAS sectype is set to 'tls1.3' and add a config
>> option NVME_TARGET_TCP_TLS.
>> And move the 'state' lock to an irq-safe lock as the 'done'
>> callback from the TLS handshake will be running in interrupt
>> context.
> 
> Really.. that is surprising. Can you describe how exactly?
> 
Ho-hum. Yes, I can, and it seems to be related to my test setup.
I'm running nvme and nvmet over the loopback interface, and with that
nvme_tcp_stop_queue() induces a softirq triggering a socket state change
on the target.
Which means that nvmet_tcp_schedule_release_queue() is called from 
softirq, triggering the spin_lock warning.
Probably warrants a separate patch, though.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare at suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman