[PATCH libnvme v2 2/2] fabrics: Do not pass disable_sqflow if not supported

Daniel Wagner dwagner at suse.de
Tue Aug 8 02:09:27 PDT 2023


On Tue, Aug 08, 2023 at 11:47:14AM +0300, Sagi Grimberg wrote:
> I think you want to check this before the initial call
> and avoid the retry altogether.
> --
> -       if (e->treq & NVMF_TREQ_DISABLE_SQFLOW)
> +       if (e->treq & NVMF_TREQ_DISABLE_SQFLOW &&
> +           nvmf_check_option(h->r, disable_sqflow))
>                 c->cfg.disable_sqflow = true;
> +       else
> +               c->cfg.disable_sqflow = false;
> 
>         if (e->trtype == NVMF_TRTYPE_TCP &&
>             (e->treq & NVMF_TREQ_REQUIRED ||

Yep, makes sense.



More information about the Linux-nvme mailing list