[PATCH 1/2] nvme-core: fix memory leak in dhchap_secret_store

[Max Gurtovoy]

On 27/04/2023 11:04, Chaitanya Kulkarni wrote:
> Free dhchap_secret in nvme_ctrl_dhchap_secret_store() before we return
> when nvme_auth_generate_key() returns error.
> 
> Signed-off-by: Chaitanya Kulkarni <kch at nvidia.com>
> ---
>   drivers/nvme/host/core.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 518c759346f0..5a9d97c0c0c1 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -3814,8 +3814,10 @@ static ssize_t nvme_ctrl_dhchap_secret_store(struct device *dev,
>   		int ret;
>   
>   		ret = nvme_auth_generate_key(dhchap_secret, &key);
> -		if (ret)
> +		if (ret) {
> +			kfree(dhchap_secret);
>   			return ret;
> +		}
>   		kfree(opts->dhchap_secret);
>   		opts->dhchap_secret = dhchap_secret;
>   		host_key = ctrl->host_key;

This doesn't solve the leak we have in case strcmp return 0 (also for 
patch 2/2).

Can you please address before sending the next version ?