[RFC PATCH 1/1] nvme: add a dedicated .c file for sysfs interface

[Max Gurtovoy]

On 24/04/2023 16:56, Jens Axboe wrote:
> On 4/24/23 7:38?AM, Sagi Grimberg wrote:
>>> diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c
>>> new file mode 100644
>>> index 000000000000..8d2aabe2d290
>>> --- /dev/null
>>> +++ b/drivers/nvme/host/sysfs.c
>>> @@ -0,0 +1,657 @@
>>> +// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB
>>
>> Linux-OpenIB ?
>>
>>> +/*
>>> + * Sysfs interface for the NVMe core driver.
>>> + *
>>> + * Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
>>
>> Not an expert in this matter, but does copy-pasting full hunk of code
>> from one file to a new one qualify for copyrights claims?
> 
> IANAL, but that seems bogus for sure. Adding a copyright claim for just
> moving code is nonsense.
> 

My bad, as I mentioned to Sagi I will remove it.
I wanted to get feedback on the concept.

If the only comments I get is for copyright then we're good I guess ?