[RFC PATCH 1/1] nvme: add a dedicated .c file for sysfs interface

Sagi Grimberg sagi at grimberg.me
Mon Apr 24 06:38:02 PDT 2023


> The core.c file became long and hard to maintain. Create a dedicated
> file to centralize the sysfs functionality. This is a common practice to
> separate sysfs/configfs related logic from the main driver logic .c file.
> For example, in the nvmet module the configfs interface has its own
> dedicated file.

Don't mind having it..

[...]

> diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c
> new file mode 100644
> index 000000000000..8d2aabe2d290
> --- /dev/null
> +++ b/drivers/nvme/host/sysfs.c
> @@ -0,0 +1,657 @@
> +// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB

Linux-OpenIB ?

> +/*
> + * Sysfs interface for the NVMe core driver.
> + *
> + * Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.

Not an expert in this matter, but does copy-pasting full hunk of code
from one file to a new one qualify for copyrights claims?



More information about the Linux-nvme mailing list