[PATCH 2/3] nvme: check IO start time when deciding to defer KA
Uday Shankar
ushankar at purestorage.com
Thu Apr 20 12:37:45 PDT 2023
On Tue, Apr 18, 2023 at 07:56:58PM +0300, Sagi Grimberg wrote:
> > + if (ctrl->kas && !ctrl->comp_seen
> > + && nvme_req(req)->start_time >= ctrl->ka_last_check_time)
> > ctrl->comp_seen = true;
>
> indentation is wrong here.
>
> > @@ -1028,6 +1027,8 @@ static inline void nvme_start_request(struct request *rq)
> > {
> > if (rq->cmd_flags & REQ_NVME_MPATH)
> > nvme_mpath_start_request(rq);
> > + else
> > + nvme_req(rq)->start_time = jiffies;
>
> nvme_mpath_start_request may not set the start_time if stats are
> disabled...
Thanks for catching these, I'll fix them up in a v2.
More information about the Linux-nvme
mailing list