[PATCH v2 1/3] nvme-hwmon: Return error on kzalloc failure
Serge Semin
Sergey.Semin at baikalelectronics.ru
Thu Sep 29 15:46:46 PDT 2022
Inability to allocate a buffer is a critical error which shouldn't be
tolerated since most likely the rest of the driver won't work correctly.
Thus instead of returning the zero status let's return the -ENOMEM error
if the nvme_hwmon_data structure instance couldn't be created.
Signed-off-by: Serge Semin <Sergey.Semin at baikalelectronics.ru>
---
Changelog v2:
- New patch
---
drivers/nvme/host/hwmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/hwmon.c b/drivers/nvme/host/hwmon.c
index 0a586d712920..1afb24a64145 100644
--- a/drivers/nvme/host/hwmon.c
+++ b/drivers/nvme/host/hwmon.c
@@ -230,7 +230,7 @@ int nvme_hwmon_init(struct nvme_ctrl *ctrl)
data = kzalloc(sizeof(*data), GFP_KERNEL);
if (!data)
- return 0;
+ return -ENOMEM;
data->ctrl = ctrl;
mutex_init(&data->read_lock);
--
2.37.3
More information about the Linux-nvme
mailing list