[PATCH 01/13] nvme: add common helpers to allocate and free tagsets

Christoph Hellwig hch at lst.de
Thu Sep 22 07:19:17 PDT 2022


On Thu, Sep 22, 2022 at 04:09:14PM +0800, Chao Leng wrote:
> Maybe we should not add the checking of NVME_F_FABRICS.
> +	if (ctrl->ops->flags & NVME_F_FABRICS) {
> +		ctrl->fabrics_q = blk_mq_init_queue(set);
> +		if (IS_ERR(ctrl->fabrics_q)) {
> +			ret = PTR_ERR(ctrl->fabrics_q);
> +			goto out_cleanup_admin_q;
> +		}
> +	}
> nvme_alloc_admin_tag_set should not check NVME_F_FABRICS either.
> The new helpers is just used for fabrics.

Right now.  As mentioned in the cover letter I plan to use it for
PCIe nvme-apple as well.  But that will need more work, including
block layer work for request_queue refcounting first.



More information about the Linux-nvme mailing list