[PATCH rfc 0/1] Fix missing AENs when discovery controllers are disconnected

Sagi Grimberg sagi at grimberg.me
Sun Sep 18 07:12:46 PDT 2022


>> The fact that the event is called rediscover semantically means that
>> this is the discovery controller. It would be weird coming on any other
>> controller, even if userspace happened to ask for it. If at all, I'd
>> prefer to fail the parameter for controllers that are not discovery
>> controller, which is strict, but at least not resulting in a weird
>> event...
> 
> yeah... I guess I fell into is "rediscover" because the controller was 
> "rediscovered" on the link ?   vs "please rediscover on a discovery 
> controller"
> 
> either way - based on other people's input is fine with me.

Didn't hear from anyone, guess it doesn't really matter.
I'll lose the user parameter, make the event fire for
any discovery controller that reconnects.



More information about the Linux-nvme mailing list