[PATCH rfc 0/1] Fix missing AENs when discovery controllers are disconnected

James Smart jsmart2021 at gmail.com
Sat Sep 10 08:47:23 PDT 2022


On 9/7/2022 7:24 AM, Sagi Grimberg wrote:
> When a discovery controller is disconnected, no AENs will
> arrive to notify the host about discovery log-page changes.
> 
> This attempts to fix it with a new connection parameter asking
> the kernel to send a dedicated udev event for this case. Prior
> attempt tried to use "connected" event already sent by the kernel
> however this also applied on the first connected, causing undesired
> side-effects when issuing a simple 'discover' command.
> 
> The patchset includes the nvme-cli/libnvme counter-parts as well.

Sagi,

Do we really need another parameter/option ?  seems awkward to need 
userspace to figure it out.

The transport certainly knows the difference between 1st time connect 
and nth time re-connect - perhaps this should be a simple flag on the 
nvme ctrl struct set by the transport ?  Simple thing for rdma/tcp to 
set flag at end of successful xxx_create_ctrl(), while FC, given it does 
reconnects w/o a first successful connect needs a little more logic.

-- james





More information about the Linux-nvme mailing list