[PATCH 1/2] nvme-auth: allocate authentication buffer only during transaction

[Hannes Reinecke]

On 10/30/22 08:52, Christoph Hellwig wrote:
>> +
>> +	/*
>> +	 * Allocate a large enough buffer for the entire negotiation:
>> +	 * 4k should be enough to ffdhe8192.
> 
> should or is?
> 
Well, is.

>> +	chap->buf_size = 4096;
> 
> why do we even need the buf_size member if it is constant?
> 
Will be hardcoding it.

>> +	chap->buf = kzalloc(chap->buf_size, GFP_KERNEL);
> 
> I think this needs to be GFP_NOIO as we can hit this during a reconnect.
Will do.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare at suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman