[PATCH] nvme: quiet user passthrough command errors

Keith Busch kbusch at kernel.org
Wed Oct 26 11:19:09 PDT 2022


On Wed, Oct 26, 2022 at 06:04:32PM +0000, Chaitanya Kulkarni wrote:
> On 10/26/2022 10:07 AM, Keith Busch wrote:
> > From: Keith Busch <kbusch at kernel.org>
> > 
> > The driver is spamming the kernel logs for entirely harmless errors from
> > user space submitting unsupported commmands. Just silence the errors.
> > The application has direct access to command status, so there's no need
> > to log these.
> > 
> > Cc: Daniel Wagner <dwagner at suse.de>
> > Cc: Alan Adamson <alan.adamson at oracle.com>
> > Signed-off-by: Keith Busch <kbusch at kernel.org>
> > ---
> 
> 
> This should do the trick, however it will be great if reporter
> can provide tested-by.

Pretty easy to test. Just send an invalid command from user space:

  # nvme admin-passthru /dev/nvme0 --opcode=0xff
  nvme0: Admin Cmd(0xff), I/O Error (sct 0x0 / sc 0x1) DNR

With the patch applied, the kernel message is suppressed.



More information about the Linux-nvme mailing list