[PATCH v2] nvme-tcp: send quota for nvme_tcp_send_all()

Sagi Grimberg sagi at grimberg.me
Wed Oct 26 01:30:50 PDT 2022


>> Daniel, does adding cond_resched() make the system responsive again?
> 
> As it turns out I can't reproduce it anymore. Our test lab got
> restructured and the cabling between machine changed (maybe even
> different network switches, idk). Also the target got a firmware
> update.
> 
> It looks more like the real problem was caused by the network
> infrastructure than the host itself. And adding the additional delay in
> the send path was just reducing the load which made the ssh session
> working.

Let's table it for now.

> Given this, I don't think we currently need to touch this code. Though
> the unbounded loop makes me a bit uneasy.

This flow only enters when there is a single request queued, so it
should not be something that takes long. Unless there is a real
problem, lets not add code that may produce one.



More information about the Linux-nvme mailing list