[PATCH 5/6] nvme-auth: don't ignore key generation failures when initializing ctrl keys
Hannes Reinecke
hare at suse.de
Tue Oct 25 10:24:42 PDT 2022
On 10/25/22 15:43, Sagi Grimberg wrote:
> nvme_auth_generate_key can fail, don't ignore it upon initialization.
>
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> ---
> drivers/nvme/host/auth.c | 19 +++++++++++++++----
> drivers/nvme/host/core.c | 6 +++++-
> drivers/nvme/host/nvme.h | 2 +-
> 3 files changed, 21 insertions(+), 6 deletions(-)
>
That was actually deliberately, as dhchap keys are optional, so wasn't
sure if a failure in parsing/generating keys should count as a 'real'
failure. But if you say so:
Reviewed-by: Hannes Reinecke <hare at suse.de>
Cheers,
Hannes
More information about the Linux-nvme
mailing list