[PATCH 03/17] nvme-pci: don't warn about the lack of I/O queues for admin controllers

Christoph Hellwig hch at lst.de
Tue Oct 25 07:40:06 PDT 2022


Admin controllers never have I/O queues, so don't warn about that fact.

Signed-off-by: Christoph Hellwig <hch at lst.de>
---
 drivers/nvme/host/pci.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 51513d263d77a..ec034d4dd9eff 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2917,7 +2917,8 @@ static void nvme_reset_work(struct work_struct *work)
 			nvme_dbbuf_set(dev);
 			nvme_unfreeze(&dev->ctrl);
 		} else {
-			dev_warn(dev->ctrl.device, "IO queues lost\n");
+			if (dev->ctrl.cntrltype != NVME_CTRL_ADMIN)
+				dev_warn(dev->ctrl.device, "IO queues lost\n");
 			nvme_kill_queues(&dev->ctrl);
 			nvme_remove_namespaces(&dev->ctrl);
 			nvme_free_tagset(dev);
@@ -2931,7 +2932,9 @@ static void nvme_reset_work(struct work_struct *work)
 			nvme_pci_alloc_tag_set(dev);
 			nvme_dbbuf_set(dev);
 		} else {
-			dev_warn(dev->ctrl.device, "IO queues not created\n");
+			if (dev->ctrl.cntrltype != NVME_CTRL_ADMIN)
+				dev_warn(dev->ctrl.device,
+					 "IO queues not created\n");
 		}
 	}
 
-- 
2.30.2




More information about the Linux-nvme mailing list