[PATCH 7/8] nvme: remove nvme_set_queue_dying
Christoph Hellwig
hch at lst.de
Fri Oct 21 06:29:50 PDT 2022
On Thu, Oct 20, 2022 at 04:10:47PM +0300, Sagi Grimberg wrote:
> I have to say that I always found nvme_kill_queues interface somewhat
> odd.
It is..
> its a core function that unquiesces the admin/io queues
> assuming that they were stopped at some point by the driver.
>
> If now there is no dependency between unquiesce and blk_mark_disk_dead,
> maybe it would be a good idea to move the unquiescing to the drivers
> which can pair with the quiesce itself, and rename it to
> nvme_mark_namespaces_dead() or something?
Yes, something like that is probably a good idea. This entire area
is a bit of a mess to say it mildly, so maybe we need to sort that
out first.
More information about the Linux-nvme
mailing list