[PATCH v6 01/23] net: Introduce direct data placement tcp offload
Jakub Kicinski
kuba at kernel.org
Thu Oct 20 22:05:40 PDT 2022
On Thu, 20 Oct 2022 13:18:16 +0300 Aurelien Aptel wrote:
> +#ifdef CONFIG_ULP_DDP
> + __u8 ulp_ddp:1;
> + __u8 ulp_crc:1;
> +#define IS_ULP_DDP(skb) ((skb)->ulp_ddp)
> +#define IS_ULP_CRC(skb) ((skb)->ulp_crc)
> +#else
> +#define IS_ULP_DDP(skb) (0)
> +#define IS_ULP_CRC(skb) (0)
> +#endif
This spews 10000 sparse warnings. I think it may be because of
the struct_group() magic. Try moving the macros outside of the struct
definition. And make it a static inline while at it, dunno why you used
a define in the first place :S
Please don't repost before Monday just for that, maybe someone will find
time to review over the weekend...
More information about the Linux-nvme
mailing list