[PATCH] nvme: ignore starting sector while error logging for passthrough requests

Pankaj Raghav p.raghav at samsung.com
Tue Oct 18 09:35:01 PDT 2022


>> In that case, should we reconsider this patch to avoid printing a garbage
>> value ((sector_t)-1) while logging error for IO passthrough commands?
> 
> We should probably do this, but it should probably go along with the
> opt-in for I/O commands.

Hmm, I think this patch will be orthogonal unless we put some of the opt-in
logic in the nvme_log_error() function itself.

Currently, we always log the error with the -1 sector value for passthrough
requests, which should be changed to print 0 so that we remain consistent
with the tracing infra. The same behavior should also be applicable when we
have the opt-in support, and the user decides to opt-in to log error for
passthrough requests.

That said, I am fine with this update going along with the opt-in support.



More information about the Linux-nvme mailing list