[PATCH] nvme: ignore starting sector while error logging for passthrough requests

[Keith Busch]

On Tue, Oct 18, 2022 at 04:45:35PM +0200, Christoph Hellwig wrote:
> On Tue, Oct 18, 2022 at 03:48:57PM +0200, Pankaj Raghav wrote:
> > The final consensus in Daniel's patch[1] seems to be adding an opt in to
> > log error only for admin commands, and logging error for user IO commands
> > will remain as is.
> 
> Hmm, is it?  I'd think even for I/O commands the opt in makes some
> sense.
> 
> > In that case, should we reconsider this patch to avoid printing a garbage
> > value ((sector_t)-1) while logging error for IO passthrough commands?
> 
> We should probably do this, but it should probably go along with the
> opt-in for I/O commands.

What's the preferred opt-in mechanism? If we want to do it per-command,
we have an unsused 'flags' field in the ioctl structures that we can
start defining options for these kinds of things. If we don't want that
level of fine grained control, we could set it at the controller or
module level with a new sysfs file, though I'm not sure this warrants
creating new exports there.