[PATCH v1] nvme: do not log errors for user commands

[Keith Busch]

On Mon, Oct 17, 2022 at 12:07:33AM -0700, Christoph Hellwig wrote:
> On Fri, Oct 07, 2022 at 09:19:08PM +0000, Alan Adamson wrote:
> > > I do get the debugging argument, but this clearly regresses production
> > > code. Ideally, this code should be opt-in. The only way I see how to make
> > > this work is by introducing a new API which allows enable this
> > > feature.
> > 
> > Looks like a new API may need to be created.  I’ll investigate that.
> > With your change, there
> > will need to be a blktests change.
> 
> Yes, I think we need to effectively revert this for user commands and
> then add an opt in - be that from the submitter, or through a sysfs
> file for all command.

Yeah, I think we should revert logging errors for user admin commands
(io command logs can probably remain). There are tools running at
regular intervals that query all devices for optional pages, and
spamming the kernel logs with these repeated errors is causing some
problems.