[PATCH v1] nvme: do not log errors for user commands

[Daniel Wagner]

On Thu, Oct 06, 2022 at 02:16:35PM +0200, Pankaj Raghav wrote:
> > +	req->rq_flags |= RQF_QUIET;
> 
> With this, we are disabling logging for ADMIN and IO commands via the
> ioctl. IMO, the error logging for IO commands could be useful for
> debugging. But I do understand your regression argument here.

I do get the debugging argument, but this clearly regresses production
code. Ideally, this code should be opt-in. The only way I see how to make
this work is by introducing a new API which allows enable this
feature.

> >  	ret = nvme_execute_passthru_rq(req, &effects);
> >  
> >  	if (result)
> 
> We can also send admin commands via the uring_cmd interface:
> nvme_dev_uring_cmd(). Should we also enable RQF_QUIET flags for them?

Good point, this path is likely to have the same problem.
 
> P.S: I sent a patch today that touches the error logging in NVMe that
> sets the starting LBA as zero for IO passthrough requests.
> https://lore.kernel.org/linux-nvme/20221006091053.36611-1-p.raghav@samsung.com/

Yes, saw your patch, but with this patch it wont do match afterwards :)