[PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag
Jeff Layton
jlayton at kernel.org
Tue Nov 29 09:42:33 PST 2022
On Tue, 2022-11-29 at 15:02 +0100, Christoph Hellwig wrote:
> Hmm. Having to set a flag to not accidentally corrupt per-task
> state seems a bit fragile. Wouldn't it make sense to find a way to opt
> into the feature only for sockets created from the syscall layer?
I agree that that would be cleaner. task_frag should have been an opt-in
thing all along. That change regressed all of the in-kernel users of
sockets.
Where would be the right place to set that flag for only userland
sockets? A lot of the in-kernel socket users hook into the socket API at
a fairly high-level. 9P and CIFS, for instance, call __sock_create.
We could set it in the syscall handlers (and maybe in iouring) I
suppose, but that seems like the wrong thing to do too.
In the absence of a clean place to do this, I think we're going to be
stuck doing it the way Ben has proposed...
--
Jeff Layton <jlayton at kernel.org>
More information about the Linux-nvme
mailing list