[PATCH] nvme-tcp: add additional info for nvme_tcp_timeout log

[Engel, Amit]

Hi Sagi.

The previous msg:
nvme nvme0: queue 0: timeout request 0x0 type 4

We found it more useful to have also:
cmd opc that was timed out
command id that was timed out
The timeout value for this specific io - in case of a timeout - it make sense to know the timeout value itself
more info about the blk rq - such as:
	a. time of a request that was allocated for the IO that was timed out
	b. time of the timed out IO that was submitted to the device

The log is already exists, why not provide additional info that can help with io timeouts debug?

Thanks,
Amit


Internal Use - Confidential

-----Original Message-----
From: Sagi Grimberg <sagi at grimberg.me> 
Sent: Monday, 21 November 2022 13:36
To: Engel, Amit <Amit.Engel at Dell.com>; linux-nvme at lists.infradead.org
Subject: Re: [PATCH] nvme-tcp: add additional info for nvme_tcp_timeout log


[EXTERNAL EMAIL] 


> Hi Sagi,
> 
> Below is an example print of a read cmd that is timed out Should I add 
> this also to the commit msg?
> nvme nvme0: queue 1: cntlid 1 timeout request 0x7 type 4 cid 28679 
> opcode 0x1 start time 5022008820ns io start time 5022008132ns request 
> timeout 5000ms

This is not an improvement from the existing msg.