[PATCH] tcp: add additional info for nvme_tcp_timeout log
Chaitanya Kulkarni
chaitanyak at nvidia.com
Wed Nov 16 10:37:22 PST 2022
On 11/16/22 05:57, amit.engel at dell.com wrote:
> From: Amit Engel <Amit.Engel at dell.com>
>
without the commit log it is hard to understand whay additional
information is needed also you need to fix the subject line..
> Signed-off-by: Amit Engel <Amit.Engel at dell.com>
> ---
> drivers/nvme/host/tcp.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
> index 1eed0fc26b3a..5abaff5d6f6e 100644
> --- a/drivers/nvme/host/tcp.c
> +++ b/drivers/nvme/host/tcp.c
> @@ -2277,8 +2277,11 @@ static enum blk_eh_timer_return nvme_tcp_timeout(struct request *rq)
> struct nvme_tcp_cmd_pdu *pdu = req->pdu;
>
> dev_warn(ctrl->device,
> - "queue %d: timeout request %#x type %d\n",
> - nvme_tcp_queue_id(req->queue), rq->tag, pdu->hdr.type);
> + "queue %d: cntlid %u timeout request %#x type %d cid %u opcode %#x "
> + "start time %lluns io start time %lluns request timeout %ums\n",
> + nvme_tcp_queue_id(req->queue), ctrl->cntlid, rq->tag, pdu->hdr.type,
> + pdu->cmd.common.command_id, pdu->cmd.common.opcode,
> + ktime_sub_ns(ktime_get(), rq->start_time_ns), ktime_sub_ns(ktime_get(), rq->io_start_time_ns), jiffies_to_msecs(rq->timeout));
>
> if (ctrl->state != NVME_CTRL_LIVE) {
> /*
More information about the Linux-nvme
mailing list