[PATCH] tests/nvme: Remove test output for passthrough error logging

Keith Busch kbusch at kernel.org
Wed Nov 16 08:48:47 PST 2022


On Wed, Nov 16, 2022 at 04:17:03AM +0000, Shinichiro Kawasaki wrote:
> On Nov 15, 2022 / 16:12, Alan Adamson wrote:
> > Commit d7ac8dca938c ("nvme: quiet user passthrough command errors")
> > disabled error logging for passthrough commands so the associated
> > error output in nvme/039.out should be removed.
> > 
> > When an error logging opt-in mechanism for passthrough commands is
> > provided, the error output can be added back.
> 
> Thanks for this quick action. This two-steps approach looks good for me.
> 
> I confirmed the fix avoids the failure with v6.1-rc5 kernel. Also, I observe
> this fix makes the test case fail with v6.0 kernel. I suggest to skip the test
> case with kernel v6.0 or older, applying the hunk below. Could you repost v2
> with this change? Or if you want, I can apply it together with v1. Please let
> me know your preference.

It sounds like some future case might allow these errors to log in some
circumstances, so I'm not sure the test case should be so dependent on
seeing or not seeing these messages. Is there a mechanism to say these
are optional messages that may or may not show up?



More information about the Linux-nvme mailing list