[PATCH v2 1/2] nvmet: expose IEEE OUI to configfs

[Aleksandr Miloserdov]

On 16.11.2022, 09:58, "Christoph Hellwig" <hch at lst.de> wrote:
>    On Tue, Nov 15, 2022 at 04:05:14PM +0200, Sagi Grimberg wrote:
>    >> index c8a061ce3ee5..48a2f587f38a 100644
>    >> --- a/drivers/nvme/target/admin-cmd.c
>    >> +++ b/drivers/nvme/target/admin-cmd.c
>    >> @@ -372,6 +372,8 @@ static void nvmet_execute_identify_ctrl(struct nvmet_req *req)
>    >>      memcpy_and_pad(id->fr, sizeof(id->fr),
>    >>                     UTS_RELEASE, strlen(UTS_RELEASE), ' ');
>    >>   +  put_unaligned_le24(subsys->ieee_oui, id->ieee);
>    >> +
>    >
>    > Any particular reason why it is placed here and not where the comment
>    > was?
>
>    Keeping the ID assignment together seems pretty reasonable to me.

Also assigning adjacent struct members in one chunk looks neat to me.