[PATCH] tests/nvme: Add admin-passthru+reset race test

[Shinichiro Kawasaki]

On Nov 15, 2022 / 01:49, Jonathan Derrick wrote:
> 
> 
> On 11/14/2022 5:25 PM, Chaitanya Kulkarni wrote:
> > On 11/14/22 12:34, Jonathan Derrick wrote:
> >> Adds a test which runs many formats and reset_controllers in parallel.
> >> The intent is to expose timing holes in the controller state machine
> >> which will lead to hung task timing and the controller becoming
> >> unavailable.
> >>
> >> Reported by https://bugzilla.kernel.org/show_bug.cgi?id=216354
> >>
> >> Signed-off-by: Jonathan Derrick <jonathan.derrick at linux.dev>
> >> ---
> > 
> > Thanks a lot for submitting this, it is really useful...
> > 
> > Overall it looks good.
> > 
> > Reviewed-by: Chaitanya Kulkarni <kch at nvidia.com>
> > 
> > -ck
> > 
> 
> Thanks
> I have v2 coming with a bit more robustness, so let's not merge this one just yet

This test case looks valuable. Thanks. When you post v2, would you mind
renumbering the test case from nvme/046 to nvme/047? Another new test case of
the nvme test group was posted [1]. Also, your check with "make check" command
will be appreciated. Shellcheck has some complaints:

$ make check
shellcheck -x -e SC2119 -f gcc check new common/* \
        tests/*/rc tests/*/[0-9]*[0-9]
tests/nvme/046:31:8: warning: attr appears unused. Verify use (or export if used externally). [SC2034]
tests/nvme/046:54:23: note: Double quote to prevent globbing and word splitting. [SC2086]
tests/nvme/046:57:12: note: $/${} is unnecessary on arithmetic variables. [SC2004]
tests/nvme/046:57:23: note: $/${} is unnecessary on arithmetic variables. [SC2004]
tests/nvme/046:80:38: note: $/${} is unnecessary on arithmetic variables. [SC2004]
tests/nvme/046:80:49: note: $/${} is unnecessary on arithmetic variables. [SC2004]
make: *** [Makefile:21: check] Error 1


[1] https://lore.kernel.org/linux-nvme/20221114125252.1086763-1-sagi@grimberg.me/

-- 
Shin'ichiro Kawasaki