[PATCH 04/12] nvme-pci: put the admin queue in nvme_dev_remove_admin
Christoph Hellwig
hch at lst.de
Tue Nov 8 22:28:08 PST 2022
On Wed, Nov 09, 2022 at 04:58:46AM +0200, Sagi Grimberg wrote:
>> @@ -2774,8 +2775,6 @@ static void nvme_pci_free_ctrl(struct nvme_ctrl *ctrl)
>> nvme_dbbuf_dma_free(dev);
>> nvme_free_tagset(dev);
>> - if (dev->ctrl.admin_q)
>> - blk_put_queue(dev->ctrl.admin_q);
>
> Is the check here valid? meaning can we get here with
> a NULL admin_q?
Yes, the admin queue is only set in the middle of nvme_reset_work,
and for errors before that we can get here.
More information about the Linux-nvme
mailing list