[PATCH] nvme: add support for TP4084 - Time-to-Ready Enhancements

Christoph Hellwig hch at lst.de
Wed May 25 09:23:42 PDT 2022


On Wed, May 25, 2022 at 04:19:04PM +0000, Niklas Cassel wrote:
> Right now we do not write CC.CRIME bit _before_ the controller is enabled.
> We set CC.CRIME and CC.ENABLE at the same time, which strictly speaking
> is not according to spec.
> 
> Should we perhaps consider splitting the write up into two,
> the first write sets everything except the enable bit,
> and the second write sets everything + the enable bit?

Actually various other CC bits require that as well.  It hasn't been
an issue so far, but we might as well fix it.  That being said to
properly fix it we'd have to read back a register after setting
CC bits to flush posted writes as well.



More information about the Linux-nvme mailing list